GPM ported
Stefan Sperling
stsp at stsp.in-berlin.de
Sun Nov 26 09:50:39 CET 2006
On Sun, Nov 26, 2006 at 12:20:26AM -0800, Troy Davis wrote:
> ok finally figured out why I was having to hardcode the /var/run path
> instead of using GPM_NODE_CTL, in gpm.h where it is defined its using an
> #ifndef _PATH_DEV ,which is defined by uClibs as /dev so i renamed the
> define to _gPATH_DEV and now it works correctly :).
But this creates a new constant :(
The goal here is to deviate from upstream as *little* as possible.
The simpler the patch, the better.
You are doing this:
-#ifndef _PATH_DEV
-#define _PATH_DEV "/dev/"
+#ifndef _gPATH_DEV
+#define _gPATH_DEV "/var/run/"
I think we should either do this:
-#ifndef _PATH_DEV
-#define _PATH_DEV "/dev/"
+#define _PATH_DEV /var/run
...
-#endif
or this, which I think is the cleanest, because
it is only a one-line change:
-#define GPM_NODE_DEV _PATH_DEV "gpmctl"
+#define GPM_NODE_DEV "/var/run/gpmctl"
--
stefan
http://stsp.in-berlin.de PGP Key: 0xF59D25F0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://mailman.dslinux.in-berlin.de/pipermail/dslinux-devel-dslinux.in-berlin.de/attachments/20061126/5c7e1e92/attachment.pgp
More information about the dslinux-devel
mailing list