r1883

[Stefan Sperling]

On Fri, Sep 14, 2007 at 12:21:28AM +0200, dslinux_amadeus at dslinux.in-berlin.de wrote:
> Author: amadeus
> Date: 2007-09-14 00:21:23 +0200 (Fri, 14 Sep 2007)
> New Revision: 1883
> 
> Log:
> Some cosmetic changes on a non-active math library

Are you sure these changes are only cosmetic?

Quoting lib/libm/atan.c:

 * Define compile time symbol ANSIC = 1 for ANSI standard,
 * range -PI < z <= +PI, args (y,x); else ANSIC = 0 for range
 * 0 to 2PI, args (x,y).

This means that ANSIC is probably *always* defined, as either 1 or 0.
If this is so, then if you replace #if with #ifdef the #else part
is *not* considered anymore at all, never ever!

> Modified: trunk/lib/libm/atan.c
> ===================================================================
> --- trunk/lib/libm/atan.c	2007-09-13 22:17:46 UTC (rev 1882)
> +++ trunk/lib/libm/atan.c	2007-09-13 22:21:23 UTC (rev 1883)
> @@ -348,7 +348,7 @@
>  	{
>  	if( code & 1 )
>  		{
> -#if ANSIC
> +#ifdef ANSIC
>  		return( -PIO2 );
>  #else
>  		return( 3.0*PIO2 );
> @@ -369,7 +369,7 @@
>  
>  switch( code )
>  	{
> -#if ANSIC
> +#ifdef ANSIC
>  	default:
>  	case 0:
>  	case 1: w = 0.0; break;
> 

-- 
stefan
http://stsp.name                                         PGP Key: 0xF59D25F0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://mailman.dslinux.in-berlin.de/pipermail/dslinux-devel-dslinux.in-berlin.de/attachments/20070914/a1e97d09/attachment.pgp