Patch for TinTin++ port

[Stefan Sperling]

On Fri, Sep 28, 2007 at 11:49:23AM -0700, Dylan McCall wrote:
>    I guess that explains why diff never works for me. Here is a much
>    smaller patch file :)
>    Hopefully it'll work. (I may have messed something up, though...)

A few notes:
 
1) You haven't patched the config files in vendor/Nintendo/*
Make sure "Update default vendor config" is set in menuconfig
and save your config with tintin++ enabled in DLDI.
The other builds will automatically get a "tintin is not enabled"
entry in their configs.


2) This just diffs whitespace:

> @@ -333,6 +337,7 @@
>  
>  	init_terminal();
>  
> +
>  	do_help(gtd->ses, "CREDITS");
>  }


3) I think the changes to Makefile.in are not necessary
because:

3a) The configure script *should* automatically use CC etc.
from the build environment. Can you verify?

If it doesn't, try forcing it like so, no need for a diff:

	cd src && env CC=${CC} LDFLAGS=${LDFLAGS} ... ./configure ...

> diff -urN tintin.orig.1.96.8/src/Makefile.in user/tintin/src/Makefile.in
> --- tintin.orig.1.96.8/src/Makefile.in	2007-03-21 02:22:21.000000000 -0700
> +++ user/tintin/src/Makefile.in	2007-09-28 11:08:48.000000000 -0700
> @@ -21,15 +21,8 @@
>  
>  DEFINES = -D_GNU_SOURCE @DEFS@
>  
> -CC = @CC@ -Wall
>  MAKE = @MAKE@
>  
> -#this is the standard CFLAGS options, this is what most people should use
> -
> -CFLAGS = $(DEFINES) @BIG5@
> -
> -LDFLAGS = @LDFLAGS@
> -
>  INCS = @MYINCLUDE@
>  
>  LIBS = @MYLIB@ @LIBS@


3b) The install: target is never called in our build system so you
can just leave it in place (smaller diff to upstream).

> @@ -80,18 +73,14 @@
>  	@exit 1
>  
>  
> -install: tt++
> -	cp tt++ /usr/bin
> -
> -
>  # Autocompile all .c files into .o files using this rule:
>  .c.o:
>  	$(CC) $(PIPE) $(CFLAGS) $(FFLAGS) $(INCS) -c $<
>  


3c) Instead of this diff you could simply make your master Makefile
call 'make clean distclean' when it is called for 'make clean'.

>  clean:
> -	rm -f *.o *~ ../*~ ../mods/*~ tt++*
> +	rm -f *.o *~ ../*~ ../mods/*~ Makefile tt++ tt++.* core config.h config.cache config.status config.log
>  
>  
>  distclean: clean
> -	rm -f *.o *~ ../*~ ../mods/*~ tt++* Makefile config.h config.status config.log config.cache
> +	rm -f Makefile config.h config.status config.log config.cache


The rest looks great.
-- 
stefan
http://stsp.name                                         PGP Key: 0xF59D25F0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.dslinux.in-berlin.de/pipermail/dslinux-devel-dslinux.in-berlin.de/attachments/20070929/3f43664d/attachment.pgp