Advent4 compile warning fix
Malcolm
malcolm.parsons at gmail.com
Tue Sep 25 21:38:46 CEST 2007
On 25/09/2007, Jonathan <echidnaman at gmail.com> wrote:
> I made a patch that reduces warnings given by advent4 by about 3/5ths.
> One of the files (turn.c) was a bit... hackish, and my current skills
> couldn't fix the warnings without creating a big, fat bug.
These are the bugs that you created:
- return;
- if (i = dcheck()) {
+ if (i == dcheck()) {
- if (place[obj] == -1)
- return;
+ if (place[obj] == -1);
- if (sptr = strchr(username, '\n'))
+ if (sptr == strchr(username, '\n'))
*sptr = '\0';
- if (sptr = strchr(username, '\r'))
+ if (sptr == strchr(username, '\r'))
*sptr = '\0';
- if (sptr = strchr(username, '.'))
+ if (sptr == strchr(username, '.'))
- while (*wptr = tolower(*wptr))
+ while (*wptr == tolower(*wptr))
- if(gaveup=yes(22,54,54))
+ if(gaveup == yes(22,54,54))
{
- if(object1 != 0)
- return;
+ if(object1 != 0);
if(object != 0) {
object1 = -1;
- return;
}
object = obj;
}
--
Malcolm Parsons
More information about the dslinux-devel
mailing list