New port

Stefan Sperling stsp at stsp.in-berlin.de
Sun Jul 2 15:50:21 CEST 2006


On Sat, Jul 01, 2006 at 09:19:06PM -0700, Troy Davis wrote:
> I have ported BitchX to dslinux, I have only have tested it on ds.gba and supercard cf running in romfs for both.
>  
> Download the original source code ircii-pana-1.1-final.tar.gz from http://bitchx.org/download.php .
>  
> The patch/diff can be downloaded from my site http://gpf.dcemu.co.uk/bitchx-patch.tar.gz
  
This is a much anticipated port! Thanks for doing this.
I hope we get this beast to run on as many builds as possible.

The patch did not work out of the box.

patch: **** malformed patch at line 28427: diff -Naur
./BitchX.org/source/tcl_public.c ./BitchX/source/tcl_public.c

which later led to lots of errors like:

tcl_public.c:22: error: 'cmd_act' undeclared here (not in a function)
tcl_public.c:23: error: 'cmd_adduser' undeclared here (not in a function)
tcl_public.c:24: error: 'cmd_boot' undeclared here (not in a function)

This was because the patch contains a binary file (.out.swp).
Please do not include binaries in patches.

Applying the patch to tcl_public.c manually solved the problem.
term.c failed to patch for the same reason.

Also, I've replaced all occurences of

	/home/ubuntu/head/dslinux/user/BitchX
	
with
	$(ROOTDIR)/user/bitchx

(Absolute paths that are specific to one computer system are obviously
rubbish.)

Likewise -L../../libncurses/lib with -L$(ROOTDIR)/lib/libncurses
and -I../../lib/libncurses/include with
-I$(ROOTDIR)/lib/libncurses/include

Please try not to use relative paths. Unfortunately, this
is done in various places in our tree, which is a bad example.

In the future, please test your patches better before sending them.
Just apply it yourself and see if it works as expected. This saves
people who want to apply them a lot of time.

thanks,
-- 
stefan
http://stsp.in-berlin.de                                 PGP Key: 0xF59D25F0



More information about the dslinux-devel mailing list